Skip to content

Add support for multi-channel enocean switches (D2-01-12 profile)#14548

Merged
balloob merged 1 commit intohome-assistant:devfrom
NoUsername:dev
Jul 9, 2018
Merged

Add support for multi-channel enocean switches (D2-01-12 profile)#14548
balloob merged 1 commit intohome-assistant:devfrom
NoUsername:dev

Conversation

@NoUsername
Copy link
Copy Markdown
Contributor

@NoUsername NoUsername commented May 19, 2018 •
edited
Loading

Description:

Adds support for multi-channel enocean switches such as these:
https://nodon.fr/en/nodon/enocean-relay-switch-2-channels/
In general this should support many devices that use the D2-01-12 enocean profile.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here> want to get a first review of this PR first

Example entry for configuration.yaml (if applicable):

# multi-channel switches can be configured like this now:
switch nodon01_0:
  - platform: enocean
    id: [0x05, 0x04, 0x03, 0x02]
    name: enocean_nodon01_0
    channel: 0

switch nodon01_1:
  - platform: enocean
    id: [0x05, 0x04, 0x03, 0x02]
    name: enocean_nodon01_1
    channel: 1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@NoUsername NoUsername requested a review from a team as a code owner May 19, 2018 22:30
houndci-bot
houndci-bot reviewed May 19, 2018
View reviewed changes
Comment thread homeassistant/components/enocean.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (105 > 79 characters)

Comment thread homeassistant/components/enocean.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected an indented block
IndentationError: expected an indented block

houndci-bot
houndci-bot reviewed May 19, 2018
View reviewed changes
Comment thread homeassistant/components/enocean.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line with same indent as next logical line

houndci-bot
houndci-bot reviewed May 19, 2018
View reviewed changes
Comment thread homeassistant/components/enocean.py Outdated
Copy link
Copy Markdown

@houndci-bot houndci-bot May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line with same indent as next logical line

syssi
syssi reviewed May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This can be merged if the const is moved.

Comment thread homeassistant/const.py Outdated
CONF_BINARY_SENSORS = 'binary_sensors'
CONF_BLACKLIST = 'blacklist'
CONF_BRIGHTNESS = 'brightness'
CONF_CHANNEL = 'channel'
Copy link
Copy Markdown
Member

@syssi syssi May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this const to the component.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 15, 2018

Any update on this @NoUsername ?

@NoUsername
Copy link
Copy Markdown
Contributor Author

NoUsername commented Jul 2, 2018

sorry for the long silence, fixed it now, hope that was how you meant it 😉

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 2, 2018

Just noticed, the documentation PR of this one is missing (or I am missing something...).

Added the docs-missing label.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 2, 2018

ok to merge when docs have been added. 👍

@NoUsername NoUsername mentioned this pull request Jul 4, 2018
Merged
1 task
@NoUsername
Copy link
Copy Markdown
Contributor Author

NoUsername commented Jul 4, 2018

created a PR for docs: home-assistant/home-assistant.io#5660

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 4, 2018

PR for the docs spotted indeed, removing the docs-missing label.

@balloob balloob merged commit 287b1bc into home-assistant:dev Jul 9, 2018
@ghost ghost removed the almost-done label Jul 9, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 9, 2018

🎉 Thanks! 🌮

awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@NoUsername @awarecan
Add support for multi-channel enocean switches (D2-01-12 profile) (ho…
573e9df 
…me-assistant#14548)
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
@NoUsername @michaeldavie
Add support for multi-channel enocean switches (D2-01-12 profile) (ho…
ad8a7d1 
…me-assistant#14548)
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@NoUsername
Add support for multi-channel enocean switches (D2-01-12 profile) (ho…
1942578 
…me-assistant#14548)
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@syssi syssi syssi left review comments

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed core integration: enocean small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@NoUsername @balloob @frenck @syssi @houndci-bot @homeassistant